Add GET method for admin logging endpoint #654
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istio-testing
added
the
size/XS
Signed-off-by: Steven Jin Xuan <t-stjinxuan@microsoft.com>
istio-testing
added
the
do-not-merge/work-in-progress
istio-testing
removed
the
do-not-merge/work-in-progress
|
/test test |
|
@Stevenjin8: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
left some similar feedback here. Not sure adding GET support to the API is the way to go. I think the dashboard ultimately just needs work on the html side IMO. That said I think this one can be addressed again post-beta |
|
I don't think we should spend any time improving the UI of this.
…On Fri, Aug 18, 2023 at 7:00 AM Greg Hanson ***@***.***> wrote:
left some similar feedback here
<#638 (comment)>.
Not sure adding GET support to the API is the way to go. I think the
dashboard ultimately just needs work on the html side IMO. That said I
think this one can be addressed again post-beta
—
Reply to this email directly, view it on GitHub
<#654 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEYGXNIH7CCPBTMYG5KVHDXV5YOJANCNFSM6AAAAAA3RVVY4I>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we can properly access the endpoint with hyperlinks. #638